refactor(language-service): add generic decorator property verifications #32252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes finding class declarations properties in decorators are applied to more generic to all properties that may be in a decorator, and adds helper methods enabling getting the property assignment of a property value and verifying that a property assignment is actually in a decorator applied to a class. This is done so that it will be easier to provide Angular definitions for decorator properties moving forward. Most immediately, this will provide decorator class verification for angular#32238.
ayazhafiz
added
feature
14 tasks
kyliau
suggested changes
Aug 22, 2019
kyliau
approved these changes
Aug 22, 2019
ngdevelop-tech
pushed a commit
to ngdevelop-tech/angular
that referenced
this pull request
Aug 27, 2019
…ons (angular#32252) This PR makes finding class declarations properties in decorators are applied to more generic to all properties that may be in a decorator, and adds helper methods enabling getting the property assignment of a property value and verifying that a property assignment is actually in a decorator applied to a class. This is done so that it will be easier to provide Angular definitions for decorator properties moving forward. Most immediately, this will provide decorator class verification for angular#32238. PR Close angular#32252
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
…ons (angular#32252) This PR makes finding class declarations properties in decorators are applied to more generic to all properties that may be in a decorator, and adds helper methods enabling getting the property assignment of a property value and verifying that a property assignment is actually in a decorator applied to a class. This is done so that it will be easier to provide Angular definitions for decorator properties moving forward. Most immediately, this will provide decorator class verification for angular#32238. PR Close angular#32252
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
arnehoek
pushed a commit
to arnehoek/angular
that referenced
this pull request
Sep 26, 2019
…ons (angular#32252) This PR makes finding class declarations properties in decorators are applied to more generic to all properties that may be in a decorator, and adds helper methods enabling getting the property assignment of a property value and verifying that a property assignment is actually in a decorator applied to a class. This is done so that it will be easier to provide Angular definitions for decorator properties moving forward. Most immediately, this will provide decorator class verification for angular#32238. PR Close angular#32252
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes finding class declarations properties in decorators are
applied to more generic to all properties that may be in a decorator,
and adds helper methods enabling getting the property assignment of a
property value and verifying that a property assignment is actually in a
decorator applied to a class.
This is done so that it will be easier to provide Angular definitions
for decorator properties moving forward. Most immediately, this will
provide decorator class verification for #32238.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information